chore(search): remove entrances array from caves Typesense index#1703
Merged
Conversation
- Remove entrances join from dbSync processRows (no longer needed) - Schema and updateInSearch already only use nbEntrances scalar Closes #1682
Paul-AUB
approved these changes
Jun 26, 2026
Paul-AUB
left a comment
Paul-AUB
left a comment
Contributor
There was a problem hiding this comment.
Clean, targeted removal. The change is correct and complete for the batch sync path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤔 What
entrancesarray join from the caves Typesense sync pipeline (api/dbSync/entities/cave.js)🤷♂️ Why
The
entrancesarray was only indexed so the frontend could derive a count via.length. WithnbEntrancesas a first-class scalar (added in #1676), the array is redundant — it wastes index RAM and inflates payloads.The frontend has migrated to use
nbEntrances(GrottoCenter/grottocenter-front#1402).🔍 How
Removed the
entrancesjoin fromprocessRowsinapi/dbSync/entities/cave.js. The Typesense schema andCaveService.updateInSearchalready only reference thenbEntrancesscalar — no changes needed there.After deploy, a full re-sync should be triggered to drop the stale
entrancesfield from existing documents in Typesense.🧪 Testing
All existing tests pass (261 passing, 0 failing). No new tests needed — this is a removal of dead code.
📸 Previews
N/A